Add unprivileged upgrade testing for Windows. #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
3 tasks
…d-upgrade-testing
cmacknz
approved these changes
May 1, 2024
|
|
Force merging as SonarQube is reporting 0% but new code added in the PR is not unit testable and integration tests have been updated. |
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* Add unprivileged upgrade testing for Windows. * Adjust to 8.14.0-SNAPSHOT as minimum. * Add SeCreateSymbolicLinkPrivilege * Simplify if unprivileged mode is supported. * Fix file access for upgrade. * Fix kill watcher process on Windows in unprivileged mode. * Fix imports. * Fix kill non child process in tests. * Fix lint. (cherry picked from commit 4d3a3f9)
4 tasks
blakerouse
added a commit
that referenced
this pull request
May 8, 2024
* Add unprivileged upgrade testing for Windows. * Adjust to 8.14.0-SNAPSHOT as minimum. * Add SeCreateSymbolicLinkPrivilege * Simplify if unprivileged mode is supported. * Fix file access for upgrade. * Fix kill watcher process on Windows in unprivileged mode. * Fix imports. * Fix kill non child process in tests. * Fix lint. (cherry picked from commit 4d3a3f9) Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds upgrade testing for unprivileged mode on Windows.
Why is it important?
Upgrade testing for unprivileged mode on Windows was not enabled.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog toolRelated issues